Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=493246 --- Comment #26 from Liang Suilong <liangsuilong@xxxxxxxxx> 2009-07-28 13:10:27 EDT --- (In reply to comment #25) > looks ok, last small things... > 1] shutter.src: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 12) > > > > 2] in %install you are creating directory named "0755" in bin/ and share/ > > > > Are there any problems? I think it is OK for us. > > > When i think about it, you probably want to do something else by following > commands: > install -d -p 0755 $RPM_BUILD_ROOT%{_bindir} > install -d -p 0755 $RPM_BUILD_ROOT%{_datadir} > cp -fr -p 0755 bin/* $RPM_BUILD_ROOT%{_bindir}/ > cp -rf -p 0755 share/* $RPM_BUILD_ROOT%{_datadir}/ > > if you want to set permissions, you have to use switch -m (for install, cp > doesn't allow this as far as I know) > from this POV i don't think that spec file is legible (incorrectly used > commands) > > I'm sorry for lag between my answers/replies, work takes more time nowadays OK, Thanks a lot. Do you mean that I should replace cp with install. I know install command only can install files but not directories. If I replace cp with install, I will need to write a lot of commands to finish an installation action. I do not believe that it is a good way to maintain a package. I remember that you ever told me that mv is illegal in the rule of package review. I read the spec file of shutter for Mandriva and PCLinuxOS. I found they are using mv not install. Here is installation script: install -d -m 0755 %{buildroot} install -d -m 0755 %{buildroot}/usr mv bin %{buildroot}/usr mv share %{buildroot}/usr So I think I modify the script to that: install -d -p 0755 $RPM_BUILD_ROOT%{_bindir} install -d -p 0755 $RPM_BUILD_ROOT%{_datadir} cp -fr bin/* $RPM_BUILD_ROOT%{_bindir}/ cp -rf share/* $RPM_BUILD_ROOT%{_datadir}/ chmod 0755 -R $RPM_BUILD_ROOT%{_bindir} chmod 0755 -R $RPM_BUILD_ROOT%{_datadir} Is it OK? I think that option -p of cp is the same as -m of install. If it is not OK, Could you help me write an installation script for shutter. Thank you. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review