Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513874 --- Comment #2 from Parag AN(पराग) <panemade@xxxxxxxxx> 2009-07-28 06:20:02 EDT --- Review: + package builds in mock (rawhide i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1534316 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 546e95dc449cdec8410edb6739a5229d5a63f644 Math-Calc-Units-1.06.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=2, Tests=64, 0 wallclock secs ( 0.03 usr 0.00 sys + 0.14 cusr 0.01 csys = 0.18 CPU) + Package perl-Math-Calc-Units-1.06-1.fc12.noarch => Provides: perl(Math::Calc::Units) = 1.06 perl(Math::Calc::Units::Compute) perl(Math::Calc::Units::Convert) perl(Math::Calc::Units::Convert::Base) perl(Math::Calc::Units::Convert::Base2Metric) perl(Math::Calc::Units::Convert::Byte) perl(Math::Calc::Units::Convert::Combo) perl(Math::Calc::Units::Convert::Date) perl(Math::Calc::Units::Convert::Distance) perl(Math::Calc::Units::Convert::Metric) perl(Math::Calc::Units::Convert::Multi) perl(Math::Calc::Units::Convert::Time) perl(Math::Calc::Units::Grammar) perl(Math::Calc::Units::Rank) Requires: /usr/bin/perl perl >= 0:5.004 perl(Carp) perl(Getopt::Long) perl(Math::Calc::Units) perl(Math::Calc::Units::Compute) perl(Math::Calc::Units::Convert) perl(Math::Calc::Units::Convert::Byte) perl(Math::Calc::Units::Convert::Combo) perl(Math::Calc::Units::Convert::Date) perl(Math::Calc::Units::Convert::Distance) perl(Math::Calc::Units::Convert::Multi) perl(Math::Calc::Units::Convert::Time) perl(Math::Calc::Units::Rank) perl(Time::Local) perl(base) perl(constant) perl(strict) perl(vars) + Not a GUI application Should: 1) Source URL worked for me is actually http://search.cpan.org/CPAN/authors/id/S/SF/SFINK/Math-Calc-Units-1.06.tar.gz update the same in SPEC. 2) Correct license tag to "GPLv2+ or Artistic" COPYING file says its GPLv2+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review