Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225913 --- Comment #5 from Peter Lemenkov <lemenkov@xxxxxxxxx> 2009-07-28 06:07:57 EDT --- The package is in so sorrow state, so it doesn't even builds on my machine. OK,here is a list of issues: * The package doesn't honours optflags. Moreover, it adds -Os ("optimize foir size") parameter to the list of GCC keys. I'm not sure whether it conflicts with our -O2, since I'm not keen in GCC tweaking. However, it may be easily removed at %prep stage (adding of something like that - sed -i s/-Os//g %{name}-%{version}/Makefile ) * ExclusiveArch directive should use macro %{ix86} instead of "i386 i586" * Use Requires(Pre,Preun) instead of Prereq * Unneeded Requires - /sbin/service * BuildRoot MUST contain at least %{name}, %{version} and %{release}. See recommended values here: https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag Although this directive is obsolete since F-10, I think it's a good idea to manually specify it, just in case, that the only spec will be used both in Fedora and in RHEL/EPEL/Whatever. * No parallel make. See below my suggestions, regarding %build section. * The long line above should be shortened ( rm -rf $RPM_BUILD_ROOT will be enough): [ "$RPM_BUILD_ROOT" != "/" ] && [ -d $RPM_BUILD_ROOT ] && rm -rf $RPM_BUILD_ROOT; * rm -rf $RPM_BUILD_ROOT must be in %install section, and not in %build * Both %build and %install sections are highly exaggerated. You don't need to manually create all these directories - "install" utility can do all this work for us. * inconsistent use of macros. Sometimes you're using $RPM_BUILD_ROOT and sometimes %{buildroot}. * No need to explicitly add Requires: glib2 * No URL tag. * Summary ended with dot. * %{_sysconfdir}/sysconfig/irqbalance should be marked ad config That's all issues, I found so far in the spec-file, but there are some issues in the init-script as well: [petro@Sulaco SPECS]$ rpmlint ../RPMS/ppc/irqbalance-* irqbalance.ppc: W: obsolete-not-provided kernel-utils irqbalance.ppc: E: malformed-line-in-lsb-comment-block # irqbalance.ppc: W: missing-lsb-keyword Required-Start in /etc/rc.d/init.d/irqbalance irqbalance.ppc: W: missing-lsb-keyword Required-Stop in /etc/rc.d/init.d/irqbalance irqbalance.ppc: W: service-default-enabled /etc/rc.d/init.d/irqbalance irqbalance.ppc: W: service-default-enabled /etc/rc.d/init.d/irqbalance 2 packages and 0 specfiles checked; 1 errors, 5 warnings. [petro@Sulaco SPECS]$ Actually, I'm not sure, whether this package should be started by default or not, but I'm sure other issues should be addressed. Here is the spec-file with all my suggestions: http://peter.fedorapeople.org/irqbalance.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review