Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513754 Gareth John <gareth.l.john@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gareth.l.john@xxxxxxxxxxxxx | |m, jussi.lehtola@xxxxxx --- Comment #1 from Gareth John <gareth.l.john@xxxxxxxxxxxxxx> 2009-07-27 20:48:49 EDT --- MUST: rpmlint must be run on every package. The output should be posted in the review. The spec will not build without removing source 1 and source 2 lines. After they were removed rpmlint gives the following errors. ------------------------------------------------------------------------- moblin-session.i386: E: no-binary The package should be of the noarch architecture because it doesn't contain any binaries. Solution:- Then you can add to SPEC file BuildArchitectures: noarch -------------------------------------------------------------------------- W: moblin-session.i386: W: non-conffile-in-etc /etc/xdg/moblin/xinitrc A non-executable file in your package is being installed in /etc, but is not a configuration file. All non-executable files in /etc should be configuration files. Mark the file as %config in the spec file. Solution:- under %files section you can add %config /etc/xdg/moblin/xinitrc ---------------------------------------------------------------------------- W: moblin-session.i386: E: non-executable-script /etc/xdg/moblin/xinitrc 0644 /bin/sh Solution:- will come soon unless you find it. ---------------------------------------------------------------------------- Also following optional guidelines "* SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [27]" The following the mandatory guidelines you should include this file in the %doc section when released upstream. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review