Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=484049 --- Comment #13 from Jerry James <loganjerry@xxxxxxxxx> 2009-07-27 17:52:58 EDT --- Sorry to take so long with this. I've been out on vacation for the last 2 weeks. Two more changes are needed. First, patch comments should appear in the header rather than on the %patch invocations in the %prep section. See https://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment. Second, the handling of patch2 is broken in two ways. First, it isn't inserted into the source RPM when building on Fedora <= 11. Indeed, the link you gave in comment #12 leads to a source RPM without the patch. Unconditionally list the patch, so that it is always present in the source RPM. Second, choosing to apply the patch based on Fedora release number will break soon; I'm preparing to push XEmacs 21.5.29 to F-11. The patch I sent should compile and run successfully on all versions of XEmacs; the point of the wrappers was to hide the differences between Emacs/older XEmacs and newer XEmacs. I think you can drop the conditionals and the BR on xemacs >= 21.5.29 and everything should work. Everything else looks fine. Make those changes and I'll approve it. Thanks for your hard work. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review