Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Test-AutoBuild - a framework for continuous, unatttended software builds https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205032 ------- Additional Comments From berrange@xxxxxxxxxx 2006-09-10 17:35 EST ------- Thanks for the review feedback. I have addressed the following issues: - Renamed the SPEC file to match SRPM name - Use macros for all path prefixes - Added buildrequires on Test::Pod and Test::Pod::Coverage - Added docs/ dir to documentation files - Use macros for all programs used in build/install where available - Fixed buildroot to comply with Fedora standards - Make use of fedora-usermgmt package for creating builder account - Ensure main package owns all directories it creates in /etc/ & perl lib dir - Fixed %pre script to create dir for account - Fixed permissions of SPEC file - Fixed patch which was not applied The reason I have a Requires on 'perl-SVK' instead of 'perl(SVK)' is because the SVK integration actually uses the 'svk' script. A requires on 'perl(SVK)' would only represent the 'SVK.pm' module, not the script, hence I have the dependancy on the package instead. Updated SPEC & SRPMs are available at the following new URLs: http://berrange.com/~dan/fedora-review/perl-Test-AutoBuild/perl-Test-AutoBuild.spec http://berrange.com/~dan/fedora-review/perl-Test-AutoBuild/perl-Test-AutoBuild-1.2.0-2.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review