Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513286 Nuno Santos <nsantos@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED Flag|fedora-review? |fedora-review+ --- Comment #3 from Nuno Santos <nsantos@xxxxxxxxxx> 2009-07-27 16:09:57 EDT --- All the issues have been addressed (details below), marking as fedora-review+ * MUST: rpmlint must be run on every package. The output should be posted in the review. OK $ rpmlint condor-ec2-enhanced-1.0-14.fc10.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint /home/nsantos/rpmbuild/RPMS/noarch/condor-ec2-enhanced-1.0-14.fc11.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. * MUST: The package must meet the Packaging Guidelines . OK * MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. OK * MUST: Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). OK * MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). OK * SHOULD: The reviewer should test that the package builds in mock. OK $ mock -r fedora-11-i386 --resultdir=./result condor-ec2-enhanced-1.0-14.fc10.src.rpm INFO: mock.py version 0.9.16 starting... State Changed: init plugins State Changed: start INFO: Start(condor-ec2-enhanced-1.0-14.fc10.src.rpm) Config(fedora-11-i386) State Changed: lock buildroot State Changed: clean State Changed: init State Changed: lock buildroot Mock Version: 0.9.16 INFO: Mock Version: 0.9.16 INFO: enabled root cache State Changed: unpacking root cache INFO: enabled yum cache State Changed: cleaning yum metadata INFO: enabled ccache State Changed: running yum State Changed: setup State Changed: build INFO: Done(condor-ec2-enhanced-1.0-14.fc10.src.rpm) Config(fedora-11-i386) 0 minutes 22 seconds INFO: Results and/or logs in: ./result INFO: Cleaning up build root ('clean_on_success=True') State Changed: lock buildroot State Changed: clean $ rpmlint ./result/condor-ec2-enhanced-1.0-14.fc11.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review