Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512954 Dan Horák <dan@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #6 from Dan Horák <dan@xxxxxxxx> 2009-07-27 04:46:13 EDT --- formal review is here, see the notes below: OK source files match upstream: c20e52f19a22cb9695b8298ca11481f3106e3c8d opencryptoki-2.2.8.tar.bz2 OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK license field matches the actual license. OK license is open source-compatible (CPL). License text included in package. OK latest version is being packaged. OK BuildRequires are proper. OK compiler flags are appropriate. OK %clean is present. OK package builds in mock (Rawhide/x86_64). OK debuginfo package looks complete. OK rpmlint is silent. OK final provides and requires look sane. N/A %check is present and all tests pass. OK no shared libraries are added to the regular linker search paths - extra ld.so.conf file added OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK correct scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK headers in devel OK no pkgconfig files. OK no libtool .la droppings. OK not a GUI app. - rpmlint complains a bit: opencryptoki.x86_64: W: non-standard-gid /var/lib/opencryptoki pkcs11 opencryptoki.x86_64: E: non-standard-dir-perm /var/lib/opencryptoki 0770 => this is correct setup opencryptoki.x86_64: W: incoherent-init-script-name pkcsslotd ('opencryptoki', 'opencryptokid') => harmless, can be ignored opencryptoki-libs.x86_64: W: non-conffile-in-etc /etc/ld.so.conf.d/opencryptoki-x86_64.conf => this is OK, the file shouldn't be edited by user opencryptoki-libs.x86_64: W: dangling-relative-symlink /usr/lib64/opencryptoki/methods ../../sbin opencryptoki-libs.x86_64: W: dangling-relative-symlink /usr/lib64/pkcs11/methods ../../sbin => this is OK opencryptoki-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/opencryptoki/stdll/libpkcs11_tpm.so opencryptoki-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/opencryptoki/stdll/libpkcs11_sw.so opencryptoki-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/opencryptoki/libopencryptoki.so => explained in spec as required, libs should be dlopen-ed probably due license compatibility reasons this package is APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review