Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473835 Jussi Lehtola <jussi.lehtola@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jussi.lehtola@xxxxxx --- Comment #5 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2009-07-26 15:11:46 EDT --- A couple of additional notes - I just sponsored Julian. (In reply to comment #4) > Notes: > -Your package should BuildRequire: python-devel instead of python Actually, python-setuptools-devel pulls in python-devel, so that's not a problem. But it's better to BR it exclusively. ** (The ./ in front of setup.py is unnecessary when run via python.) ** I suggest using autoarchive instead of %{name} in the %files section for consistency. ** Requires: lzma is not enough IMHO. The package seems to need also tar, gzip and bzip2. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review