Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513731 leigh scott <leigh123linux@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |leigh123linux@xxxxxxxxxxxxx | |m Component|Package Review |ppp AssignedTo|nobody@xxxxxxxxxxxxxxxxx |jskala@xxxxxxxxxx --- Comment #4 from leigh scott <leigh123linux@xxxxxxxxxxxxxx> 2009-07-25 17:50:29 EDT --- These files aren't part of the package and should be removed %{_libdir}/bbtether/conf/.svn/all-wcprops %{_libdir}/bbtether/conf/.svn/dir-prop-base %{_libdir}/bbtether/conf/.svn/entries %{_libdir}/bbtether/conf/.svn/format %{_libdir}/bbtether/conf/.svn/prop-base/rogers-chat.svn-base %{_libdir}/bbtether/conf/.svn/text-base/att-chat.svn-base %{_libdir}/bbtether/conf/.svn/text-base/att.svn-base %{_libdir}/bbtether/conf/.svn/text-base/porta-chat.svn-base %{_libdir}/bbtether/conf/.svn/text-base/porta.svn-base %{_libdir}/bbtether/conf/.svn/text-base/rogers-chat.svn-base %{_libdir}/bbtether/conf/.svn/text-base/rogers.svn-base %{_libdir}/bbtether/conf/.svn/text-base/sprint-chat.svn-base %{_libdir}/bbtether/conf/.svn/text-base/sprint.svn-base %{_libdir}/bbtether/conf/.svn/text-base/tmobile-bb-chat.svn-base %{_libdir}/bbtether/conf/.svn/text-base/tmobile-chat.svn-base %{_libdir}/bbtether/conf/.svn/text-base/tmobile-data-chat.svn-base %{_libdir}/bbtether/conf/.svn/text-base/tmobile-epc-chat.svn-base %{_libdir}/bbtether/conf/.svn/text-base/tmobile-vpn-chat.svn-base %{_libdir}/bbtether/conf/.svn/text-base/tmobile.svn-base %{_libdir}/bbtether/conf/.svn/text-base/verizon-chat.svn-base %{_libdir}/bbtether/conf/.svn/text-base/verizon.svn-base %{_libdir}/bbtether/conf/.svn/tmp/tempfile.tmp %{_libdir}/bbtether/img/.svn/all-wcprops %{_libdir}/bbtether/img/.svn/entries %{_libdir}/bbtether/img/.svn/format %{_libdir}/bbtether/img/.svn/prop-base/berry4all.png.svn-base %{_libdir}/bbtether/img/.svn/text-base/berry4all.png.svn-base %{_libdir}/bbtether/osx/.svn/all-wcprops %{_libdir}/bbtether/osx/.svn/entries %{_libdir}/bbtether/osx/.svn/format %{_libdir}/bbtether/udev/.svn/all-wcprops %{_libdir}/bbtether/udev/.svn/entries %{_libdir}/bbtether/udev/.svn/format %{_libdir}/bbtether/udev/.svn/text-base/99-bbtether.rules.svn-base %{_libdir}/bbtether/udev/.svn/text-base/99-bbtether_user.rules.svn-base %{_libdir}/bbtether/udev/.svn/text-base/README.txt.svn-base This also need correcting %install rm -rf $RPM_BUILD_ROOT mkdir -p $RPM_BUILD_ROOT%{_libdir}/bbtether/ mkdir -p $RPM_BUILD_ROOT/usr/bin/ mkdir -p $RPM_BUILD_ROOT/etc/udev/rules.d cp udev/99-bbtether.rules $RPM_BUILD_ROOT/etc/udev/rules.d cp -R ./* $RPM_BUILD_ROOT%{_libdir}/bbtether/ echo cd %{_libdir}/bbtether > bbtether echo ./berry4all.sh >> bbtether chmod a+x bbtether mv bbtether $RPM_BUILD_ROOT/usr/bin %clean rm -rf $RPM_BUILD_ROOT %files /usr/bin/bbtether /etc/udev/rules.d/99-bbtether.rules should be http://fedoraproject.org/wiki/Packaging:RPMMacros#Valid_RPM_Macros %install rm -rf $RPM_BUILD_ROOT mkdir -p $RPM_BUILD_ROOT%{_libdir}/bbtether/ mkdir -p $RPM_BUILD_ROOT%{_bindir} mkdir -p $RPM_BUILD_ROOT%{_sysconfdir}/udev/rules.d cp udev/99-bbtether.rules $RPM_BUILD_ROOT%{_sysconfdir}/udev/rules.d cp -R ./* $RPM_BUILD_ROOT%{_libdir}/bbtether/ echo cd %{_libdir}/bbtether > bbtether echo ./berry4all.sh >> bbtether chmod a+x bbtether mv bbtether $RPM_BUILD_ROOT%{_bindir} %clean rm -rf $RPM_BUILD_ROOT %files %{_bindir}/bbtether %config(noreplace) %{_sysconfdir}/udev/rules.d/99-bbtether.rules The source URL is not correct http://fedoraproject.org/wiki/Packaging/SourceURL#Using_Revision_Control URL: http://www.colar.net/websvn/filedetails.php?repname=src&path=%2Fbbtether%2Fbbtether.tgz Source0: bbtether.tgz -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review