Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513733 --- Comment #1 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2009-07-25 05:30:52 EDT --- - Package does not build in mock. setup.py tries to run gtk-update-icon-cache, which is missing in the buildroot. To fix this, remove the call by running sed -i /gtk-update-icon-cache/d setup.py in the %prep phase. - Incorrect(?) dependencies: according to docs/DEPENDENCIES Requires: pyclutter-cairo should be pycairo Requires: python-storm-sqlite should be python-storm - Unnecessary dependencies Requires: pyclutter-gtk Requires: pyclutter-gst Drop these if you don't have a valid reason to have them. - Missing Requires: hicolor-icon-theme for dir ownership. Please add also the macros to update the icon cache https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache ** rpmlint output is clean. MUST: The package does not yet exist in Fedora. The Review Request is not a duplicate. OK MUST: The spec file for the package is legible and macros are used consistently. OK - Please add an empty line (or two as you seem to use) between %build and %install. MUST: The package must be named according to the Package Naming Guidelines. OK - Not a (pure) python module so naming is OK. MUST: The spec file name must match the base package %{name}. OK MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK MUST: The License field in the package spec file must match the actual license. OK MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. OK MUST: The package MUST successfully compile and build into binary rpms. OK MUST: The spec file MUST handle locales properly. OK MUST: Optflags are used and time stamps preserved. OK MUST: A package must own all directories that it creates or require the package that owns the directory. OK MUST: Files only listed once in %files listings. NEEDSWORK - For consistency, use %{_bindir}/entertainer* instead of %{_bindir}/%{name}* (You could also list the four files explicitly.) - Change %{python_sitelib}/entertainerlib* to %{python_sitelib}/entertainerlib/ and %{python_sitelib}/Entertainer-0.4-py2.6.egg-info to %{python_sitelib}/Entertainer-*.egg-info as you otherwise won't be able to build the spec file in Fedora 10 which has Python 2.5. - Change %{_datadir}/entertainer* to %{_datadir}/entertainer/ - Change %{_datadir}/icons/hicolor/* to %{_datadir}/icons/hicolor/*/apps/entertainer.png (You don't want to own system directories.) MUST: Debuginfo package is complete. N/A MUST: Permissions on files must be set properly. OK MUST: Clean section exists. OK MUST: Large documentation files must go in a -doc subpackage. N/A - developer_documentation.pdf is 237K, which is OK compared to the rest of the package. MUST: All relevant items are included in %doc. Items in %doc do not affect runtime of application. OK MUST: Desktop files are installed properly. OK MUST: No file conflicts with other packages and no general names. OK MUST: Buildroot cleaned before install. OK SHOULD: %{?dist} tag is used in release. OK SHOULD: If the package does not include license text(s) as separate files from upstream, the packager should query upstream to include it. OK SHOULD: The package builds in mock. OK -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review