[Bug 513541] Review Request: cpulimit - CPU Usage Limiter for Linux

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513541





--- Comment #12 from Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx>  2009-07-25 04:34:00 EDT ---
(In reply to comment #11)
> Added man file in make.

To the Makefile? Is in this case the line 'install -Dp -m 644 man/cpulimit.1
$RPM_BUILD_ROOT%{_mandir}/man1/cpulimit.1' still needed?

> Should I bump the version each and every time I fix something here? (I bumped
> it)

Everytime you make a change, bump the release.  As Itamar already said, this
avoid
confusion.

> I have no idea how to fix the time stamps issue...please advise if you do.

You can use 'make install INSTDIR=$RPM_BUILD_ROOT INSTALL="install -p"' instead
of 'make install DESTDIR=$RPM_BUILD_ROOT '. You can change this later when
everything is upstream but often it don't harm when it's added before it takes
effect.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]