Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513541 --- Comment #9 from Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> 2009-07-24 18:55:33 EDT --- Your patch add several files. The AUTHORS, COPYING, and all other documentation files should go in %doc. There is a rpmlint warning. This is easy to fix ;-) [root@laptop09 i586]# rpmlint cpulimit* cpulimit.i586: W: incoherent-version-in-changelog 1.1 ['1.1-2.fc11', '1.1-2'] 2 packages and 0 specfiles checked; 0 errors, 1 warnings. A blank line between the changelog entry blocks make the whole changelog easier to ready. One suggestion: Would it make the life of upstream easier if the man page is installed within the Makefile? The time stamps are not preserved (https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps). Almost all files are generated with the patch so this will affect after a new upstream release. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review