Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226062 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@xxxxxxxxx, | |peter.hutterer@xxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flag| |fedora-review? --- Comment #4 from Parag AN(पराग) <panemade@xxxxxxxxx> 2009-07-24 06:55:11 EDT --- Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1497503 - rpmlint is NOT silent for SRPM and for RPM. libX11.src: W: name-repeated-in-summary libX11 libX11.src: W: strange-permission make-git-snapshot.sh 0775 libX11.i686: W: name-repeated-in-summary libX11 libX11.i686: W: shared-lib-calls-exit /usr/lib/libX11.so.6.2.0 exit@xxxxxxxxx libX11-common.noarch: W: summary-not-capitalized libX11 common data + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + lx11.pc and x11-xcb.pc file present. + -devel subpackage present. + no .la files. + no translations are available + Does owns the directories it creates. + ldconfig scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package libX11-1.2.99-2.20090712.fc12.i686 => Provides: libX11-xcb.so.1 libX11.so.6 Requires: libX11-xcb.so.1 libX11.so.6 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.2) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.2) libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.3.2) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libdl.so.2 libdl.so.2(GLIBC_2.0) libdl.so.2(GLIBC_2.1) libxcb.so.1 rtld(GNU_HASH) + Package libX11-devel-1.2.99-2.20090712.fc12.i686 => Provides: pkgconfig(x11) = 1.2.99.1 pkgconfig(x11-xcb) = 1.2.99.1 Requires: /usr/bin/pkg-config libX11-xcb.so.1 libX11.so.6 pkgconfig(kbproto) pkgconfig(x11) pkgconfig(xcb) pkgconfig(xcb) >= 1.1.92 pkgconfig(xproto) + Not a GUI application Suggestions: 1) Fix rpmlint messages about summary. 2) follow http://fedoraproject.org/wiki/PackagingGuidelines#Timestamps -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review