Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=513253 Mark McLoughlin <markmc@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |markmc@xxxxxxxxxx --- Comment #3 from Mark McLoughlin <markmc@xxxxxxxxxx> 2009-07-23 08:56:44 EDT --- Suggest adding %{?dist} >From bug #199688 I see %{extra_release} is for autobuilder - worth a comment, it's not obvious %{perlvendorarch} is unused Any particular reason for the %{perlversion} requirement? Doesn't seem normal for perl packaging, is it? What perl version is actually required? Do you need this: https://fedoraproject.org/wiki/Packaging/Perl#Versioned_MODULE_COMPAT__Requires Just tried to build, used yum-builddep to install the build deps and got: Checking prerequisites... - ERROR: Test::Pod::Coverage is not installed - ERROR: Test::Pod is not installed - ERROR: XML::XPath is not installed although it built okay, anything to worry about? Apart from that looks good to me: $ rpmlint perl-Sys-Virt-TCK-0.1.0-2.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint perl-Sys-Virt-TCK.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. and scott's FAIL items are sorted -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review