Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pgpool - Connection pooling/replication server for PostgreSQL https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199679 kevin@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@xxxxxxxxxxxxx |kevin@xxxxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From kevin@xxxxxxxxx 2006-09-09 20:57 EST ------- See below - Package name OK - Spec file matches base package name. OK - Meets Packaging Guidelines. OK - License (BSD) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 8adb39f18780a93e4b2ac0e31364314d pgpool-3.1.1.tar.gz 8adb39f18780a93e4b2ac0e31364314d pgpool-3.1.1.tar.gz.1 OK - Package compiles and builds on at least one arch. OK - BuildRequires correct OK - Package owns all the directories it creates. OK - Package has no duplicate files in %files. OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Spec has consistant macro usage. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package doesn't own any directories other packages own. See below - No rpmlint output. SHOULD Items: OK - Should include License or ask upstream to include it. OK - Should build in mock. Issues: 1. Should this package be named 'postgresql-pgpool', since it "enhances or adds a new functionality to an existing Fedora Core or Fedora Extras package without being useful on its own" 2. rpmlint says: W: pgpool incoherent-version-in-changelog 3.1.1-4 3.1.1-3.fc6 Might fix the changelog to not have .fc6 in it. (minor). 3. I'd have to agree with the point in comment #9 about the /etc/pgpool.conf.sample file. You should either construct a /etc/pgpool.conf file for there, or ship no config file and put the .sample file under doc or the like. Looking at that file I think you could just install it as /etc/pgpool.conf and let the end user modify it if they have a diffrent config. 4. Is the "Requires: postgresql-server" correct? Couldn't this run on a machine with no local postgresql-server installed, talking to remote machines with it installed? 5. In agreement with comment #9 again, you shouldn't need to pass anything to the %configure macro. You have: %configure --sysconfdir=%{_sysconfdir} --mandir=%{_mandir} --libdir=%{_libdir} but %configure expands to a configure call that already passes all those values. You can simply have: %configure See /usr/lib/rpm/macros for more information. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review