Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512627 Jussi Lehtola <jussi.lehtola@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jussi.lehtola@xxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |jussi.lehtola@xxxxxx Flag| |fedora-review? --- Comment #1 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2009-07-21 13:16:43 EDT --- BLOCKER: You need to package PgsLookAndFeel separately and make MiniCopier use the separate package. [No bundling of external libraries.] https://pgslookandfeel.dev.java.net/ - You have to comment your patches. - The patches are incorrectly named; their names have to begin with %{name}. - The package is noarch, so there's no need for %global debug_package %{nil} - The license is GPLv2+ not GPLv2. - Drop the line chmod 0644 %{SOURCE0} which serves no purpose. - If you make backups of the original files in patching with -b, use different suffixes for different patches. - I suggest using install -D -p -m 644 %{name}.jar $RPM_BUILD_ROOT%{_javadir}/%{name}.jar instead of mkdir -p $RPM_BUILD_ROOT%{_javadir} cp %{name}.jar lib/*.jar $RPM_BUILD_ROOT%{_javadir} and the same for the png file. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review