Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507958 --- Comment #5 from Andrew Overholt <overholt@xxxxxxxxxx> 2009-07-21 10:50:28 EDT --- A few more minor things: - you have ${_jvmdir} and %{_jvmdir} - this is weird: $RPM_BUILD_ROOT%{install_loc} ... please use %{buildroot}%{install_loc}. In fact, please s/$RPM_BUILD_ROOT/%{buildroot}/g in the whole file - do what Alex suggests for the doc files Thanks for dealing with the qualifier situation. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review