Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511246 --- Comment #3 from Andrew Beekhof <andrew@xxxxxxxxxxx> 2009-07-20 10:59:05 EDT --- New spec and source rpm (this time for f12): http://oss.clusterlabs.org/~beekhof/fedora/pacemaker.spec http://oss.clusterlabs.org/~beekhof/fedora/pacemaker-1.0.4-2.fc12.src.rpm Conducted a self-review based on http://fedoraproject.org/wiki/Packaging/ReviewGuidelines and made a number of improvements. In particular the spec now references the upstream tarball, the summaries are a little better and (after reading the discussion regarding #!env python fedora-packaging) the wrong-script-interpreter errors have been removed. Here is the new rpmlint output (previous explanations of the remaining errors and warnings still apply): rpmlint ~/rpmbuild/RPMS/x86_64/*pace* pacemaker.spec libpacemaker3.x86_64: W: shared-lib-calls-exit /usr/lib64/libcrmcluster.so.1.0.0 exit@xxxxxxxxxxx libpacemaker3.x86_64: W: shared-lib-calls-exit /usr/lib64/libpengine.so.3.0.0 exit@xxxxxxxxxxx libpacemaker3.x86_64: W: shared-lib-calls-exit /usr/lib64/libcib.so.1.0.1 exit@xxxxxxxxxxx libpacemaker3.x86_64: W: no-documentation libpacemaker-devel.x86_64: W: no-dependency-on libpacemaker/libpacemaker-libs/liblibpacemaker libpacemaker-devel.x86_64: W: no-documentation pacemaker.x86_64: E: non-standard-dir-perm /var/lib/pengine 0750 pacemaker.x86_64: E: non-standard-dir-perm /var/lib/heartbeat/crm 0750 pacemaker.x86_64: E: script-without-shebang /usr/share/pacemaker/constraints-1.0.rng pacemaker.x86_64: E: script-without-shebang /usr/share/pacemaker/crm.dtd pacemaker.x86_64: E: script-without-shebang /usr/share/pacemaker/pacemaker.rng pacemaker.x86_64: E: script-without-shebang /usr/share/pacemaker/rule-1.0.rng pacemaker.x86_64: E: script-without-shebang /usr/share/pacemaker/score.rng pacemaker.x86_64: E: script-without-shebang /usr/share/pacemaker/nvset-1.0.rng pacemaker.x86_64: E: script-without-shebang /usr/share/pacemaker/upgrade06.xsl pacemaker.x86_64: E: script-without-shebang /usr/share/pacemaker/pacemaker-1.0.rng pacemaker.x86_64: E: script-without-shebang /usr/share/pacemaker/resources-1.0.rng pacemaker.x86_64: E: non-standard-dir-perm /var/run/crm 0750 pacemaker.x86_64: E: script-without-shebang /usr/share/pacemaker/crm-transitional.dtd pacemaker.spec:166: E: hardcoded-library-path in /usr/lib/ocf pacemaker.spec:167: E: hardcoded-library-path in /usr/lib/ocf/resource.d pacemaker.spec:168: E: hardcoded-library-path in /usr/lib/ocf/resource.d/pacemaker 4 packages and 1 specfiles checked; 16 errors, 6 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review