Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=510734 --- Comment #8 from Christian Krause <chkr@xxxxxxxxxxx> 2009-07-19 04:53:39 EDT --- I've roughly scanned over the package (http://hubbitus.net.ru/rpm/Fedora11/x11vnc/x11vnc-0.9.8-3.fc11.src.rpm ) and before I do a complete review please fix the following issues: - lots of rpmlint errors: * README/AUTHORS not UTF-8, please convert them in the %prep section via iconv (please make sure to preserve the timestamp, e.g. by using "touch -c -r old_file" * wrong permissions of some of the *.c files, please change the permission to 644 in the %prep section - the indentation seems to be broken - just open the file with vim or gedit - please delete the commented Packager: and Vendor: tags, it should be sufficient to add to your first changelog entry that this spec file is based on a version from Dag Wieers <dag@...> - delete the old non-Fedora changelog entries - correct the Source: line * use Source0 for the primary source file * for sf.net please use something like this: http://downloads.sourceforge.net/libvncserver/%{name}-%{version}.tar.gz * see also http://fedoraproject.org/wiki/Packaging:SourceURL for details * verify via "spectool -g x11vnc.spec" whether the sources can be downloaded using the provided URL - does not build in rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=1484978 - probably a missing build requirement since X11/extensions/XInput.h can't be found - check for spelling mistakes in the comments ;-) ("pathc") - the source as well as the built package contain some java clients: * only the server components are mentioned in the %description * if the clients should be shipped, then put them into separate sub-package * it is not allowed to use the pre-built JARs * preferably the pre-built JARs should not even be shipped in the sources (see http://fedoraproject.org/wiki/Packaging:Java for details) - "Requires: minilzo" is wrong, since there is no package "minilzo". Since x11vnc is linked against libminilzo.so.0, the dependency should be automatically added to the binary rpm: rpm --requires -qp ~rpmbuild/RPMS/i386/x11vnc-0.9.8-3.fc10.i386.rpm |grep lzo libminilzo.so.0 - would it be an option to use the system's libvncserver library instead of the internal one? (--use-system-libvncserver - when you upload a new version, please also provide also a link to the spec file - this makes it easier to just have a quick look at it -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review