Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511895 --- Comment #2 from Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> 2009-07-18 20:11:19 EDT --- Here is my review for this package. Most are minor things but there is a license issue. - Package builds in koji rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=1484535 - rpmlint is silent * Package fails to build on F-11: checking for CLUTTER... configure: error: Package requirements (glib-2.0 clutter-0.9 >= 0.9.3) were not met: No package 'clutter-0.9' found I think this BR on clutter-devel should contain the explicit version requirement. Is this package for rawhide only? ! All relevant doc files should be packaged. It would be good to include the AUTHORS and ChangeLog files in %doc * The files clutter-imtext.{c,h} are LGPLv3. The rest is LGPLv2. AFAIK These are incompatible. This needs to be clarified by upstream. ! BR's automake, autoconf are unnecessary since these will always be dragged in by libtool. Similarly, BR's glib2-devel, pkgconfig will be dragged in by clutter-devel. However, it is not a blocker to keep them. * It looks like the devel package should require clutter-devel. There are other dependencies as well such as glib2-devel, pango-devel. But these will be dragged in by clutter-devel. ! The %{name} macro could be used more consistently. ? Do we need to package the Makefile* stuff in %doc? One last suggestion: You could use "%doc doc/*" instead of just "%doc doc/" to avoid an extra subdirectory. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review