Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=510651 Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fabian@xxxxxxxxxxxxxxxxx --- Comment #2 from Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> 2009-07-18 11:21:19 EDT --- Just some other comments - 'Source: ftp://ftp.nsk.su/pub/RinetSoftware/%name-%version.tgz' should be 'Source: ftp://ftp.nsk.su/pub/RinetSoftware/%{name}-%{version}.tgz' - Isn't 'ncurses' automatically picked up during the build process? - Why aren't you using parallel build for make? https://fedoraproject.org/wiki/Packaging:Guidelines#Parallel_make - Often it's possible to change the installation target with PREFIX=%{_prefix} - The man pages are automatically compressed during the build process. (In reply to comment #1) > It seems like the spec comes from altlinux? It would be nice to state the > explicit and give them credit. Perhaps we don't want to keep their old > changelog. I agree with Mads. Just give them some credits and drop the old changelog entries. For the Fedora spec file they have no value. (In reply to comment #1) > I suggest that URL should point to the english version at > http://soft.risp.ru/trafshow/index_en.shtml . It is just the man page with a > link to a site (in russian) where it can be downloaded. I could however not > connect to the ftp download site and verify. But it seems like they only have > trafshow-4.0.tgz available for download? Where do trafshow-5.2.3.tgz come from? I not able to connect too. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review