Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509936 Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fabian@xxxxxxxxxxxxxxxxx --- Comment #2 from Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> 2009-07-18 11:05:38 EDT --- Just some comments after a quick look at your spec file: - There are translations, gettext is missing https://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files - You can drop '-n tortoisehg-%{version}' from the %setup, this is the default The licensing situation is a bit wired. PKG-INFO says GPLv2, hggtk/logview/colormap.py says GPLv2+, and contrib/nautilus-thg.py says GPL. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review