Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libatomic_ops - Atomic memory update operations https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204579 j.w.r.degoede@xxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |j.w.r.degoede@xxxxxx CC|j.w.r.degoede@xxxxxx | OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From j.w.r.degoede@xxxxxx 2006-09-09 04:43 EST ------- I see that this indeed is a special package and that making a .so for it is of of little use. MUST: ===== O rpmlint output is: E: libatomic_ops-devel invalid-spec-name libatomic_ops.spec Tihs must be fixed, see below * Package and spec file named appropriately * Packaged according to packaging guidelines * License ok (but license file not included) * spec file is legible and in Am. English. * Source matches upstream (sortof) * "Compiles" and builds on FC-5 i386 * BR: ok * No locales * No shared libraries * Not relocatable * Package owns / or requires all dirs * No duplicate files & Permissions ok * %clean & macro usage OK * Contains code only * %doc does not affect runtime, and isn't large enough to warrent a sub package * no -devel package needed, no libs / .la files. * no .desktop file required Must Fix ======== * "Name:" should be "libatomic_ops" not "libatomic_ops-devel", then add a subpackage -devel, with the same Summary and Description and only add a "%files devel" and not a normal "%files", then rpmbuild will only generate a -devel package * Remove "%define debug_package %{nil}" code gets generated from both the .c and the .h files, people may need this for debugging * Remove the execute rights from src/atomic_ops.h in "%prep", one we get a debuginfo rpmlint will start complaining about the unneeded execute rights, as these stay preserved in the debuginfo package * Since you have no use for these remove them instead of commenting them: " #BuildRequires: #Requires: " * Once you've fixed the "Name:" drop the "-n xxx" argument to "%setup" * Once you've fixed the "Name:" do a search and replace for atomic_ops with %{name}, everywhere except in the "URL:". Should fix: =========== * You can write all this: %dir %{_includedir}/atomic_ops %{_includedir}/atomic_ops/*.h %dir %{_includedir}/atomic_ops/sysdeps %{_includedir}/atomic_ops/sysdeps/* As just: %{_includedir}/%{name} * And this: %dir %{_datadir}/libatomic_ops %{_datadir}/libatomic_ops/* as: %{_datadir}/lib%{name} * Also concider replacing: %{_libdir}/libatomic_ops.a %{_libdir}/libatomic_ops_gpl.a With: %{_libdir}/lib%{name}*.a * Etc. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review