Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tuxpaint-stamps - Extra stamp files for tuxpaint https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204852 kevin@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |kevin@xxxxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From kevin@xxxxxxxxx 2006-09-09 02:04 EST ------- OK - Package name OK - Spec file matches base package name. OK - Meets Packaging Guidelines. OK - License (GPL) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 6edf92504b1b9f9943e3b28011738691 tuxpaint-stamps-2005.11.25.tar.gz 6edf92504b1b9f9943e3b28011738691 tuxpaint-stamps-2005.11.25.tar.gz.1 OK - Package compiles and builds on at least one arch. OK - BuildRequires correct OK - Spec handles locales/find_lang OK - Package owns all the directories it creates. OK - Package has no duplicate files in %files. OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Spec has consistant macro usage. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package doesn't own any directories other packages own. See below - No rpmlint output. SHOULD Items: OK - Should include License or ask upstream to include it. OK - Should build in mock. Issues: 1. The rpmlint error: E: tuxpaint-stamps incorrect-locale-sv /usr/share/locale/sw/LC_MESSAGES/ tuxpaint-stamps.mo seems to be saying that sw is a invalid locale, and should be sv? >From the I18NCheck.py file in rpmlint: # Associative array of invalid value => correct value INCORRECT_LOCALES = { 'in': 'id', 'in_ID': 'id_ID', 'iw': 'he', 'iw_IL': 'he_IL', 'gr': 'el', 'gr_GR': 'el_GR', 'cz': 'cs', 'cz_CZ': 'cs_CZ', 'sw': 'sv', 'lug': 'lg', # 'lug' is valid, but we standardize on 2 letter codes 'en_UK': 'en_GB'} So perhaps move the sw locale files to the sv directory? I think sw is not a valid locale, so those files should be sv files. I see tuxpaint itself does this as well, perhaps a bug should be filed against it? Thats the only issue I see here. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review