Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512217 --- Comment #11 from Dominic Hopf <dmaphy@xxxxxxxxx> 2009-07-17 12:57:38 EDT --- (In reply to comment #4) (In reply to comment #4) > Also, while I realize that Jochen requested the release number to be rewound to > 1, it's a little bit disingenious to remove the changelog attribution to the > work done by Pierre Yvess and myself in generating the spec file prior to > review. It doesn't actually matter to me, and may not matter to Pierre either, > but in general you shouldn't remove record of people's work as it might affect > their employment when they work on things for Fedora as part of their day job. > Say I was asked by my boss to package geany plugins and work on getting it into > Fedora. If he looks now, it looks like I didn't do any work, and I get the sack > (ok, this isn't a real example, but you see my point). I definitely see this point. Please note that it was not my intention to be disingenuous. My idea was to leave the fedora review and the changelog as it was with Pierres and your work. Since Jochen told me to start with review 1 I was not sure what the right way was. Would it be also ok if I mention your somewhere else, e.g. in the changelog text? I reverted back to the docdir-solution suggested by Jonathan so far to fix the issue with the versioned directory, but I still want to clarify the zero-length-files issue with upstream. Also replaced geany-plugins with the %{name} macro in the %files section. Updated files under same URLs: http://dominichopf.de/geany-plugins/geany-plugins.spec http://dominichopf.de/geany-plugins/geany-plugins-0.17-1.fc11.src.rpm md5sums to avoid confusion: 128df7eaa577b77024e9c84a94849c57 geany-plugins.spec aae25a11d3cf2ce8c464e6f41323bd63 geany-plugins-0.17-1.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review