Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512217 Jonathan Underwood <jonathan.underwood@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.underwood@xxxxxxxx | |m --- Comment #4 from Jonathan Underwood <jonathan.underwood@xxxxxxxxx> 2009-07-17 12:14:20 EDT --- Hi Dominic, Jochen, Removing the docdir congifure option is totally the wrong thing to do - not ALL of the doc files are empty, only some of them. Removing the empty files would be more appropriate. doc files are supposed to be installed under a versioned directory in /usr/share/doc By removing the docdir configure option, the doc files end up installed in /usr/share/doc/geany-plugins rather than /usr/share/doc/geany-plugins-0.17 Also, while I realize that Jochen requested the release number to be rewound to 1, it's a little bit disingenious to remove the changelog attribution to the work done by Pierre Yvess and myself in generating the spec file prior to review. It doesn't actually matter to me, and may not matter to Pierre either, but in general you shouldn't remove record of people's work as it might affect their employment when they work on things for Fedora as part of their day job. Say I was asked by my boss to package geany plugins and work on getting it into Fedora. If he looks now, it looks like I didn't do any work, and I get the sack (ok, this isn't a real example, but you see my point). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review