Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511938 --- Comment #4 from Mike Bonnet <mikeb@xxxxxxxxxx> 2009-07-16 18:24:57 EDT --- %{_sysconfdir}/sysconfig/cld should be %config(noreplace) Mixing %{buildroot} and $RPM_BUILD_ROOT in %install COPYING should be included in %doc You might want to consider including the date and git revision in the Release (and removing git from the version) as outlined here: https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Snapshot_packages rpmlint output: $ rpmlint -v *.rpm cld.i586: I: checking cld.i586: W: non-conffile-in-etc /etc/sysconfig/cld - Bogus warning. cld.i586: W: service-default-enabled /etc/rc.d/init.d/cld - The service should not be enabled by default, according to: https://fedoraproject.org/wiki/Packaging/SysVInitScript - Also according to that page, it looks like the Default-Stop line is used incorrectly. cld.i586: W: incoherent-subsys /etc/rc.d/init.d/cld $prog - Bogus. cld.i586: W: service-default-enabled /etc/rc.d/init.d/cld - See above. cld-debuginfo.i586: I: checking cld-devel.i586: I: checking License is good. After the package review is complete you need to file bugs for ExlcludeArch'ing ppc and ppc64, mark them as blockers for FE-ExcludeArch-ppc and FE-ExcludeArch-ppc64 respectively, and reference the bug numbers in the spec file. The comment about endianness is good enough as a placeholder for now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review