Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=501573 --- Comment #13 from Mike Bonnet <mikeb@xxxxxxxxxx> 2009-07-16 15:02:34 EDT --- rpmlint output: $ rpmlint ndoutils-1.4-0.3.b7.fc12.x86_64.rpm ndoutils-mysql-1.4-0.3.b7.fc12.x86_64.rpm ndoutils-pgsql-1.4-0.3.b7.fc12.x86_64.rpm ndoutils.x86_64: W: non-standard-uid /var/log/ndoutils nagios ndoutils.x86_64: W: non-standard-uid /var/run/ndoutils nagios ndoutils.x86_64: W: non-standard-uid /var/cache/ndoutils nagios ndoutils.x86_64: W: log-files-without-logrotate /var/log/ndoutils ndoutils.x86_64: W: incoherent-init-script-name ndo2db ndoutils-mysql.x86_64: W: no-documentation ndoutils-pgsql.x86_64: W: no-documentation All of them are explained satisfactorily above. The GPLv2 license is mentioned in a few of the source files, but you may want to encourage upstream to include a LICENSE or COPYING file in the source tarball. A better URL might be http://www.nagios.org/download/addons/, but I'll leave that decision to you. The Source0 URL should be: Source0: http://downloads.sourceforge.net/nagios/ndoutils-1.4b7.tar.gz in accordance with: https://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net Tarball in .src.rpm matches upstream tarball. Koji scratch build succeeded on all arches: https://koji.fedoraproject.org/koji/taskinfo?taskID=1480076 The %files sections for the mysql and pgsql subpackages need %defattr lines (I don't think this changes anything, but it's in the guidelines). It seems very odd to be dropping a .o file into %{_libdir} (rather than a versioned .so). Is this customary for nagios addons? Are there other packages that do this? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review