Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512217 Jochen Schmitt <jochen@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jochen@xxxxxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |jochen@xxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #2 from Jochen Schmitt <jochen@xxxxxxxxxxxxxxx> 2009-07-16 14:55:45 EDT --- Good: + Basename of the SPEC file matches with package name + Package name fullfill naming guidelines + URL tag shows on proper project homepage + Package contains most recent release of the application + Could download package tar ball via spectool -g + Package contains valid License tag + License tag states GPLV2+ as a valid OSS license + License state in the license tag matches with copyright notes on the souces + Package contains proper BuildRoot definition + BuildRoot will cleaned at the beginning of %clean and %install + Package contains verbain copy of the license tag + Package tar ball matches with upstream (md5sum: 9da6ab5bebd5e7de306b4dd3d1c9a5b4) + Consistently usage of rpm macros + Package has no subpackages + Package has a SMP-enabled build step + Local build works fine + Debuginfo package contains sources + Scratch build on koji works fine. + Package files has proper file permission + All packaged files are owned by the package + %file stanza has no duplicate entries + No package file belong to another packer + Package contains a small %doc stanza Bad: - You should start with review 1 for the Fedora package - Rpmlint has issues with source package: geany-plugins.src:64: W: macro-in-%changelog _datadir geany-plugins.src:67: W: macro-in-%changelog files geany-plugins.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 12) 1 packages and 0 specfiles checked; 0 errors, 3 warnings. Please keep in mind to escape '%' in the changelog section with a additional '%' char. - Rpmlint complaints on binary package: geany-plugins.x86_64: W: obsolete-not-provided geanyvc geany-plugins.x86_64: E: zero-length /usr/share/doc/geany-plugins-0.17/geanyvc/AUTHORS geany-plugins.x86_64: E: zero-length /usr/share/doc/geany-plugins-0.17/geanylipsum/AUTHORS geany-plugins.x86_64: E: zero-length /usr/share/doc/geany-plugins-0.17/geanyvc/ChangeLog geany-plugins.x86_64: E: zero-length /usr/share/doc/geany-plugins-0.17/addons/ChangeLog 1 packages and 0 specfiles checked; 4 errors, 1 warnings. - Because the package contains empty document files I would to avoid the usage of the --docdir option on ./configure -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review