Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509160 Andrew McNabb <amcnabb@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amcnabb@xxxxxxxxxxx --- Comment #1 from Andrew McNabb <amcnabb@xxxxxxxxxxx> 2009-07-15 21:17:20 EDT --- Björn, I'm not a sponsored package reviewer, but I have a few thoughts. 1) As you noted, rpmlint gave an error about the buildroot. I would recommend adding something like "BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)". I don't know anything about the line being ignored, but even if the line just makes it happy, it's can't hurt. 2) The package is called mine_detector, but the packaging guidelines prohibits using underscores. Consider using a hyphen instead. See https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Separators 3) It's great that you have a description in two languages. 4) The package lists PragmARC-devel as a build dependency, but there does not seem to be any package with that name in Fedora 11. As a result, I was unable to build a binary package. You mentioned that PragmARC-devel is part of a separate request, but I think you should really work towards getting that one accepted before submitting new requests that depend on it. Good luck. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review