Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=489014 Toshio Ernie Kuratomi <a.badger@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |a.badger@xxxxxxxxx --- Comment #44 from Toshio Ernie Kuratomi <a.badger@xxxxxxxxx> 2009-07-15 02:59:15 EDT --- GOOD: * Package follows the naming guidelines * spec file is appropriately named * spec file is in Englishand legible * No SRPM provided -- Source URL is canonical * Package builds on x86 and x86_64 * Package does not build on ppc and ppc64 with an appropraite comment as to why - Once the package isapproved and has a bugzilla component, please open a bug and have it block the ppc trackers: : https://bugzilla.redhat.com/show_bug.cgi?id=179260 : https://bugzilla.redhat.com/show_bug.cgi?id=238953 - remember to add the bug # to the comments in the spec file * gnome-do-plugins-0.8.1 does not have language files so no %find_lang is needed. From what I'm reading, gnome-do-plugins-0.8.2 has some language catalogs so be sure to use %find_lang to mark the language files when updating to that version. * Not a dynamic library * Not relocatable * All directories are owned * rpmlint:All the subpackages have this: - gnome-do-plugins-banshee.i586: W: summary-not-capitalized gnome-do plugin for banshee : This is fine since we're referencing the gnome-do package - gnome-do-plugins-banshee.i586: W: no-documentation : Documentation is in the main gnome-do-plugins package So both of these are fine. - gnome-do-plugins.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 11) : The SRPM has this note that spaces and tabs are mixed. This is cosmetic but is easily solved by changing tabs into spaces everywhere in the spec file. * No files or directories owned twice. * Permissions set properly * Proper %clean section * macros used consistently * Package builds in koji. NEEDSWORK: * License should be GPLv3+ * The files need to install in %{_libdir}/gnome-do/plugins - gnome-do may or may not require patching to find plugins in that directory. I found this entry in the curent gnome-do's Do/src/Do.Core/Paths.cs but I don't know precisely what it does:: yield return AppDomain.CurrentDomain.BaseDirectory.Combine (PluginsDirectory); * Main package needs to Require: gnome-do * Something needs to provide the %{_libdir}/gnome-do/plugins directory and all the plugin subpackages that install in there need to Require that package. Currently, the gnome-do-plugins package provides that directory but none of the other subpackages Require: gnome-do-plugins. There's two possible solutions: 1) Have all the other packages Require: gnome-do-plugins. 2) Since all the plugins Require: gnome-do already, have the main gnome-do package own that directory instead of gnome-do-plugins. COSMETIC: * The noted mixing of spaces and tabs * Since the patch is no longer requiredfor building, you can take it out instead of simply commenting it -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review