Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=510969 --- Comment #36 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2009-07-14 10:39:46 EDT --- - I'm still quite not sure about the Requires of the devel package Requires: libxml2-devel >= %{libxml2_version} Requires: intltool The upstream page http://www.valaide.org/content/download doesn't say anything about these. libxml2 is needed to run, but that requirement is already there. I'd drop these. - Drop the %doc from -devel. -devel requires the main package which already contains the same documentation. - You could be more verbose in your changelog comments. "Fix spec file" doesn't tell you anything. - Version the BuildRequires: vala-devel and gtk2-devel. The build should fail if the dependencies are not there. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review