Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=510969 --- Comment #26 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2009-07-14 08:30:20 EDT --- - You didn't increment the release tag. Please increment the release tag whenever making changes to the spec file. (Except when the version tag is incremented the release tag falls back to 1.) - Drop Requires: vala >= %{vala_version} and put the version requirement in the Requires: vala-devel. (dependency on vala is automatically picked up, also vala-devel pulls it in.) - Devel package doesn't have to Requires: vala-devel >= %{vala_version} since this requirement is already in the main package. Drop it. - The BuildRequires line is unnecessarily long. Please divide it in at least two separate lines. - You should add comments to the %post and %postun sections. Now it's a bit unclear to the reader what is the purpose of the commands. - For clarity of the spec file you could remove some of the empty lines within the sections, %build, %install, %post and %postun are a bit too sparse compared to their environment. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review