Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=510698 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #4 from Parag AN(पराग) <panemade@xxxxxxxxx> 2009-07-14 05:59:49 EDT --- Review: + package builds in mock (rawhide i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1472652 - rpmlint is NOT silent for RPM. klavaro.i586: E: setgid-binary /usr/bin/klavaro_helper root 02755 The file is setgid. Usually this is a packaging bug. If this is a game, then, you should use the proper rpm group, or location. klavaro.i586: E: non-standard-executable-perm /usr/bin/klavaro_helper 02755 A standard executable should have permission set to 0755. If you get this message, it means that you have a wrong executable permissions in some files included in your package. + source files match upstream url b69ab99f94525902ca8d1f12fb46c041ad9cb5ba klavaro-1.2.1.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + translations are available + Does owns the directories it creates. + gtk-update-icon-cache scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Desktop file installed correctly. + GUI application Should: 1) Correct license tag to GPLv3+ APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review