Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=507943 Jussi Lehtola <jussi.lehtola@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #8 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2009-07-14 05:00:32 EDT --- (In reply to comment #7) > > > > MUST: Optflags are used and time stamps preserved. NEEDSWORK > > > > - Time stamps are lost during install. Adding INSTALL="install -p" as argument > > > > to make install should do the trick. > > > > > > I couldn't find anything about this in packaging guidelines. > > > > It's sort of implicitly assumed in > > https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps > > > > I sent a request to add the mention of it to the FPC. > > OK, I'll update it when its in the packaging guidelines. I don't see that it > should block the review as I only see it there when copying files within the > install section. The only one that does that is the utf-8 stuff which preserves > it as per the details you provided above. The purpose is to have the same time stamps on files that are not architecture specific in order to avoid trouble with multilib/multiarch packages. Adding the INSTALL="install -p" doesn't harm anything. I guess I can't flunk this review on that grounds, so the package is APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review