Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gwyddion https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187294 ------- Additional Comments From pertusus@xxxxxxx 2006-09-08 05:32 EST ------- (In reply to comment #21) > (In reply to comment #20) > The dependencies are always met. Any 3rd party perl plug-in requires perl > itself as any other perl script does. Any 3rd party python plug-in requires > python itself, etc. Indeed this should be the case, but the gwyddion internal modules requires the interpreter, so they should pull it in. > The dependency chain is > > plug-in -> gwyddion, perl > > not > > plug-in -> gwyddion -> perl Not quite. The dependency chain is plug-in -> gwyddion 'internal' module usefull externally, unfortunately not packaged as a normal perl module -> perl Otherwise, you can simplify the spec file by having %{_libexecdir}/%{name}/ in the %files section of the subpackage that holds the plugins. Indeed nothing under %{pkglibexecdir}/ is needed in other subpackage. The files section for doc may also be simplified to %doc %{_datadir}/gtk-doc/html/ and you can drop the %define gtkdocdir %{_datadir}/gtk-doc/html similarly, you can have %{_datadir}/%{name}/ in -libs and %{_includedir}/%{name}/ in -devel and drop the corresponding defines. Other simplifications using the same trick are also possible, like %{pkglibdir}/ruby/ instead of %{pkglibdir}/ruby/gwyddion/* %dir %{pkglibdir}/ruby/gwyddion %dir %{pkglibdir}/ruby and %{pkglibdir}/modules/ %dir %{pkglibdir} for the whole %files modules section, and other you can find by yourself. If you prefer to keep the extensive list, I have nothing against it, both approaches have merits and faults. Indeed a short list is more readable, while an extensive list allows to know when something changed. However, you should replace everywhere things like %{pkglibdir}/python/Gwyddion/* %dir %{pkglibdir}/python/Gwyddion by the equivalent and simpler %{pkglibdir}/python/Gwyddion/ (note the the trailing / is optional, but it helps a lot since it shows that it is a directory). Another comment, it seems to me that gwyddion-doc shouldn't own %{_datadir}/gtk-doc/ but it issems to be casually done by other packages, so it may be kept as is. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review