[Bug 510969] Review Request: valide - New Package IDE for vala

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=510969


Jussi Lehtola <jussi.lehtola@xxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jussi.lehtola@xxxxxx




--- Comment #13 from Jussi Lehtola <jussi.lehtola@xxxxxx>  2009-07-13 06:44:17 EDT ---
Have you even read the packaging guidelines..?

- Explicit requires are forbidden, at least those on gtk2, gtksourceview2,
sqlite and unique are automatically picked up by rpm.
http://fedoraproject.org/wiki/Packaging/Guidelines

- You have a big bunch of unowned directories.
 %{_includedir}/valide-0.5/
 %{_libdir}/plugins/ (this doesn't look correct!)
 %{_datadir}/pixmaps/valide/
 %{_datadir}/vala/vapi/
 %{_datadir}/valide/
Also the %files section is way too long.

- Desktop file is not installed correctly.
http://fedoraproject.org/wiki/Packaging/Guidelines

- Locales are not handled properly.
 "Using %{_datadir}/locale/* is strictly forbidden"
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]