Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=510913 Jason Tibbitts <tibbs@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx Flag| |fedora-review+ --- Comment #1 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2009-07-12 15:28:11 EDT --- Builds fine; rpmlint is silent. I have to ask, though I seem to recall that php makes makes it difficult: is it possible to run the test in the "tests" directory? I'm pretty sure it's not, so I don't think it's worth holding this package up waiting for an answer. I note that your packaging template has changed a bit from the one currently in the guidelines. For example, the php_zend_api conditional is missing. I understand that for this package it's pointless because you know that PHP will be new enough, but perhaps it may be work revisiting that guideline page * source files match upstream. sha256sum: cf6fdff2f5d7c98f9093bcf1c159721aeff42e5a15607dcd24113a6af517b401 ncurses-1.0a.0.tgz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: config(php-pecl-ncurses) = 1.0.0-1.fc12 ncurses.so()(64bit) php-ncurses = 5.3.0 php-pecl(ncurses) = 1.0.0-1.fc12 php-pecl-ncurses = 1.0.0-1.fc12 php-pecl-ncurses(x86-64) = 1.0.0-1.fc12 = /bin/sh /usr/bin/pecl config(php-pecl-ncurses) = 1.0.0-1.fc12 libncurses.so.5()(64bit) libpanel.so.5()(64bit) php(api) = 20041225 php(zend-abi) = 20060613 ? %check is not present, but there seems to be a test suite present. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * scriptlets are OK (pecl module registration) * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la files. APPROVED The package review process needs reviewers! If you haven't done any package reviews recently, please consider doing one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review