Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491430 --- Comment #33 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-07-12 14:12:31 EDT --- Would you answer this question? (In reply to comment #31) > Well, for 0.9-45: > > * Tarball > - First of all, is the tarball used in the srpm formally > released 0.9 tarball or 0.9 tarball is not yet released > formally? For -46: * Macros definition ------------------------------------------------------------ %{!?log_dir:%define log_dir /%{_localstatedir}/log/slog} %{!?sslogger_user:%define sslogger_user slogger} %{!?sslogger_group:%define sslogger_group sloggers} ------------------------------------------------------------ - Move these lines of defining macros to the top of the spec file. Defining macros between %description and %pre is error-prone. * Requires - By the way why is "Requires(pre): util-linux" needed? * Cosmetic issue - Well, for consistency please use %{_sysconfdir} instead of %_sysconfdir .... Then: ================================================================= NOTE: Before being sponsored: This package will be accepted with another few work. But before I accept this package, someone (I am a candidate) must sponsor you. Once you are sponsored, you have the right to review other submitters' review requests and approve the packages formally. For this reason, the person who want to be sponsored (like you) are required to "show that you have an understanding of the process and of the packaging guidelines" as is described on : http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored Usually there are two ways to show this. A. submit other review requests with enough quality. B. Do a "pre-review" of other person's review request (at the time you are not sponsored, you cannot do a formal review) When you have submitted a new review request or have pre-reviewed other person's review request, please write the bug number on this bug report so that I can check your comments or review request. Fedora package collection review requests which are waiting for someone to review can be checked on my wiki page: http://fedoraproject.org/wiki/User:Mtasaka#B._Review_request_tickets (Check "No one is reviewing") Review guidelines are described mainly on: http://fedoraproject.org/wiki/Packaging/ReviewGuidelines http://fedoraproject.org/wiki/Packaging/Guidelines http://fedoraproject.org/wiki/Packaging/ScriptletSnippets -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review