[Bug 197413] Review Request: php-pear-Net-Curl - PEAR: OO interface to PHP's cURL extension

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-pear-Net-Curl - PEAR: OO interface to PHP's cURL extension
Alias: php-pear-Net-Curl

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197413





------- Additional Comments From tibbs@xxxxxxxxxxx  2006-09-07 21:41 EST -------
Hmm, it looks like you install the LICENSE file in %prep, but it doesn't seem to
make it into the final package.

* source files match upstream:
   6a26900c1111336aa45615d4a3a4f66a  Net_Curl-1.2.3.tgz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* rpmlint is silent (except for the usual bogus dangerous-command warning)
* final provides and requires are sane:
   php-pear(Net_Curl) = 1.2.3
   php-pear-Net-Curl = 1.2.3-1.fc6
  =
   /bin/sh
   /usr/bin/pear
   php-pear(PEAR)
* %check is not present; no test suite upstream.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (PEAR module installation)
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]