Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491430 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #31 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-07-11 12:26:05 EDT --- Well, for 0.9-45: * Tarball - First of all, is the tarball used in the srpm formally released 0.9 tarball or 0.9 tarball is not yet released formally? * License - Now the license tag should be "GPLv3+" * %description ============================================================== %description A keystroke logging utility for privileged user escalation %{!?log_dir:%define log_dir /%{_localstatedir}/log/slog} %{!?sslogger_user:%define sslogger_user slogger} %{!?sslogger_group:%define sslogger_group sloggers} %if 0%{?rhel} Requires(pre): shadow-utils util-linux %else Requires(pre): shadow-utils util-linux-ng %endif ============================================================== %pre -------------------------------------------------------------- - These lines (before %pre like) are all in %description. Actually $ rpm -qi shows that "Requires(pre)" _comment_ is included in %description ! By the way on Fedora "util-linux-ng" provides "util-linux" so this conditional requires is not strictly needed. * Macros - Use %_sysconfdir instead of /etc. https://fedoraproject.org/wiki/Packaging/RPMMacros * Parallel make - Support parallel make if possible. If not possible, write some comments that parallel make is disabled on the spec file: https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make * Timestamps - When using "install" or "cp" commands, add "-p" option to keep timestamps on installed files: https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps * Permission - Please check the permissions of installed files and set them properly. * Usually normal files should have 0644 permission * From rpmlint: --------------------------------------------------------------- sslogger.i586: E: incoherent-logrotate-file /etc/logrotate.d/sslogger_rotate --------------------------------------------------------------- - It seems that this logrote file should be named as %_sysconfdir/logrotate.d/%{name} * %changelog format - It is useful in Fedora CVS system that one line is inserted between each %changelog entry like: --------------------------------------------------------------- %changelog * Sun Jul 05 2009 Ed Brand <edbrand@xxxxxxxxxxxx> - 09-40 - Split man files into slog, sslogger and sreplay - Chmod 775 $log_dir to allow normal user access - Add check to slog to disallowe passing '-' when -c option is used * Tue May 18 2009 Ed Brand <edbrand@xxxxxxxxxxxx> - 0.9-32 - removed $global * Sun Mar 29 2009 Ed Brand <edbrand@xxxxxxxxxxxx> - 0.9-30 - Change Licence to GPLv3 - Misc. spec file fixes --------------------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review