Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-pear-Image-GraphViz - PEAR: Interface to AT&T's GraphViz tools Alias: pear-Image-GraphViz https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196827 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-09-07 20:23 EST ------- Cool. Builds OK and rpmlint has only it's usual dangerous-command-in-%post spew which should be ignored. * source files match upstream: 8828e58960e0d93820cb3bdcce85e705 Image_GraphViz-1.2.1.tgz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * rpmlint is silent (except for erroneous warnings) * final provides and requires are sane: php-pear(Image_GraphViz) = 1.2.1 php-pear-Image-GraphViz = 1.2.1-1.fc6 = /bin/sh /usr/bin/pear graphviz php-pear(PEAR) * %check is not present; no test suite upstream. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * scriptlets are OK (PEAR module installation) * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review