Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=509445 Steve Traylen <steve.traylen@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |steve.traylen@xxxxxxx --- Comment #3 from Steve Traylen <steve.traylen@xxxxxxx> 2009-07-10 11:05:45 EDT --- Hi Praveen, This is not an official review as am trying to become a package maintainer myself. Things to change I would say: 1) $ rpmlint sblim-cmpi-rpm.spec sblim-cmpi-rpm.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 2) 2) There should be an initial changelog entry. See http://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs 3) The build fails with checking for CMPI headers... checking standard... checking /usr/include/cmpi... checking /usr/local/include/cmpi... checking /src/Pegasus/Provider/CMPI... checking /opt/tog-pegasus/include/Pegasus/Provider/CMPI... checking /usr/include/Pegasus/Provider/CMPI... checking /usr/include/openwbem... checking /usr/sniacimom/include... configure: error: no. Sorry cannot find CMPI headers files. so I must be missing a BuildRequires I guess. Steve -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review