[Bug 510104] Review Request: epic5 - an ircII chat client

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=510104


Randall Berry <randyn3lrx@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |randyn3lrx@xxxxxxxxx




--- Comment #4 from Randall Berry <randyn3lrx@xxxxxxxxx>  2009-07-10 02:01:25 EDT ---
spec file is a mess use macros instead of hard coded path.

http://www.fedoraproject.org/wiki/Packaging:RPMMacros
/usr/share/epic5/script/ should be %{_datadir}/%{name}/script

Package must own all directories it creates.

http://www.fedoraproject.org/wiki/Packaging/Guidelines#FileAndDirectoryOwnership
use %dir %{_datadir}/%{name} and %dir %{_datadir}/%{name}/script


Shorten list by using %{_datadir}/%{name}/script/*

No %changelog entry

Package does not build as is.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]