Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=471231 --- Comment #10 from David Nalley <david@xxxxxxx> 2009-07-09 23:22:14 EDT --- (In reply to comment #5) > New SRPM: http://monnerat.fedorapeople.org/WebCalendar-1.2.0-5.fc12.src.rpm > _ hkit unbundled. php-hkit (review request 505358) required > _ PHPMailer unbundled. php-PHPMailer (review request 505356) required > _ captcha unbundled. php-captchaphp (review request 505354) required > _ JSCookMenu unbundled. JSCookMenu (review request 505360) required Wow, that's a ton of work - I know I have reviewed one, I'll check on the rest this weekend and see their status and if not reviewed will punch them out this weekend. <snip> > > rpmlint output: > WebCalendar.noarch: W: dangling-symlink > /usr/share/WebCalendar/includes/classes/phpmailer/class.smtp.php > /usr/share/php/class.smtp.php > WebCalendar.noarch: W: non-standard-gid /etc/WebCalendar/settings.php apache > WebCalendar.noarch: E: non-readable /etc/WebCalendar/settings.php 0660 > WebCalendar.noarch: W: dangling-symlink > /usr/share/WebCalendar/includes/classes/hKit/hkit.class.php > /usr/share/php/hkit.class.php > WebCalendar.noarch: W: non-standard-gid /etc/WebCalendar apache > WebCalendar.noarch: E: non-standard-dir-perm /etc/WebCalendar 0775 > WebCalendar.noarch: W: dangling-symlink > /usr/share/WebCalendar/includes/classes/phpmailer/class.phpmailer.php > /usr/share/php/class.phpmailer.php > > New warnings (i.e.: dangling-symlinks) are symbolic links to files in the > required packages mentioned above. > > _ I did not contact Ray Jones, since its captcha updates are now deleted from > the package. OK > _ There are still files in the menu subdir: these are WebCalendar-specific menu > themes for JSCookMenu. OK > _ Everaldo's icons are retained for now: they are used by the specific menu > themes. I left a question at WebCalendar's forum about icons licensing > (https://sourceforge.net/forum/forum.php?thread_id=3299158&forum_id=11587), but > I have no answer yet. So I see - Are the icons replaceable with the crystal stuff? The crystal project is LGPL (http://www.everaldo.com/crystal/?action=license) - so it works, but as you noted they aren't 1 to 1 exacts. This is the largest issue that is looming. > _ There is still a module I have tried to unbundle: popups.php. It uses some > Javascript code (infobox.js) from Klaus Knopper's web site > (http://www.knopper.net), but although this original code is GPL2, it has never > been publicly released (there is no home page for this script: it is only > accessible as a part of Knopper's site). In addition, both versions have been > changed in incompatible ways. Thus unbundling this code and making it a > maintainable package is hardly feasible: I suggest we live with it as now. I don't foresee a problem with this at the moment, largely because the entire Javascript within the packaging guidelines is a murky matter. There may come a time in the future when this is different, but certainly for now this seems acceptable. > _ Unbundling captchaphp was a pain the the ass, because it was not initially > intended to be used this way ! I bet -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review