Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=471231 --- Comment #8 from David Nalley <david@xxxxxxx> 2009-07-09 22:47:13 EDT --- Hey Patrick I am still working through this review - and much later than I originally intended :( A quick question for you; where did all of the patches come from? Did you generate them? Did they come from upstream? Take a look at this: https://fedoraproject.org/wiki/Packaging/Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment If this is stuff you generated - we need to push them to upstream and annotate the spec file. If these patches are from upstream we need to document that as well, though I don't think there is much of a point in doing so to each one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review