Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492815 --- Comment #23 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-07-09 12:22:31 EDT --- For -0.9: * License - As now all CC-BY-SA part is removed the license for main package should be "LGPLv2+". * optflags - Fedora specific compilatin flags are not honored: ------------------------------------------------------------------- 118 FIFE msvc9 project file succesfully created (/builddir/build/BUILD/fife-2009.0_r2951/build/win32/build_environments/visual_studio_9/fife.vcproj) 119 g++ -o engine/core/audio/soundclip.os -c -fPIC -Wall -ggdb -O0 -D_GNU_SOURCE=1 -D_REENTRANT -DLOG_ENABLED -DHAVE_ZIP -DHAVE_OPENGL -I/opt/include -I/usr/include/vorbis -I/usr/include/python2.6 -I/usr/include/SDL -Iext/install/include -Iengine/core -Iengine/swigwrappers engine/core/audio/soundclip.cpp 120 g++ -o engine/core/audio/soundemitter.os -c -fPIC -Wall -ggdb -O0 -D_GNU_SOURCE=1 -D_REENTRANT -DLOG_ENABLED -DHAVE_ZIP -DHAVE_OPENGL -I/opt/include -I/usr/include/vorbis -I/usr/include/python2.6 -I/usr/include/SDL -Iext/install/include -Iengine/core -Iengine/swigwrappers engine/core/audio/soundemitter.cpp 121 g++ -o engine/core/audio/soundmanager.os -c -fPIC -Wall -ggdb -O0 -D_GNU_SOURCE=1 -D_REENTRANT -DLOG_ENABLED -DHAVE_ZIP -DHAVE_OPENGL -I/opt/include -I/usr/include/vorbis -I/usr/include/python2.6 -I/usr/include/SDL -Iext/install/include -Iengine/core -Iengine/swigwrappers engine/core/audio/soundmanager.cpp ------------------------------------------------------------------- * Removing rpath - Would you try to remove rpath by modifyin SConscript or so instead of using chrpath binary? As far as I tried the following is enough for this package: ------------------------------------------------------------------- %prep %setup -q -n %{name}-%{version}_%{revision} .... .... sed -i.rpath -e "/-rpath/s|LINKFLAGS=\[.*\]|LINKFLAGS=\[''\]|" engine/SConscript ------------------------------------------------------------------- ( Currently I cannot understand why this -rpath direction is written in engine/SConscript ) * Installing binaries ------------------------------------------------------------------- install -m0644 engine/lib*.so \ %{buildroot}%{_libdir}/%{name}/engine .... chmod +x %{buildroot}%{_libdir}/%{name}/engine/lib%{name}.so ------------------------------------------------------------------- * Identical binaries ------------------------------------------------------------------- 282 extracting debug info from /builddir/build/BUILDROOT/fife-2009.0-0.9.r2951svn.fc12.i386/usr/lib/fife/engine/swigwrappers/python/_fife.so 283 extracting debug info from /builddir/build/BUILDROOT/fife-2009.0-0.9.r2951svn.fc12.i386/usr/lib/fife/engine/libfife.so 284 *** WARNING: identical binaries are copied, not linked: 285 /usr/lib/fife/engine/libfife.so 286 and /usr/lib/fife/engine/swigwrappers/python/_fife.so ------------------------------------------------------------------- - Is this correct? If so, would you consider to use symlink? * Calling ldconfig - Calling /sbin/ldconfig on %post{,un} is not needed for this package because no libraries are installed under the default libraries search path. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review