[Bug 508416] Review Request: rubygem-mkrf - Making C extensions for Ruby a bit easier

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=508416





--- Comment #1 from Lubomir Rintel <lkundrak@xxxxx>  2009-07-08 13:27:05 EDT ---
(In reply to comment #0)
> There are many rpmlint warining/errors on -doc subpackage, however
> these are on examples and I think they are safe to ignore.  

Agreed.

* Package named correctly
* Macros used consistently
* Builds fine in mock
* Requires/provides sane
* filelist mostly sane (see below)
* rpmlint mostly ok (see below)
* spec file clean and legible
  (well, you could improve indentation in %globals paragraph :)

Needs work:

1.) Tests failing. According to the comments you seem to be aware of that. Not
blocking a review.

2.) Rpmlint

rubygem-mkrf.noarch: E: non-readable
/usr/lib/ruby/gems/1.8/cache/mkrf-0.2.3.gem 0600

You probably want to change this via %attr in %files or change the mode in
%install or something.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]