[Bug 507052] Review Request: Panini - A tool for creating perspective views from panoramic and wide angle images

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507052





--- Comment #7 from Ankur Sinha <sanjay.ankur@xxxxxxxxx>  2009-07-08 11:37:24 EDT ---
(In reply to comment #6)
> [not a review, just trying to help]
> 
> I have a spec for an earlier version of Panini here:
> http://bpostle.fedorapeople.org/reviews/Panini/Panini.spec
> 
> You might find some useful stuff, in particular you are not running
> update-desktop-database in %post and %postun (ignore the update-mime-database
> bit, I have it wrong).
> 

Thanks for this.I've added this portion.However, I don't know what the command
is responsible for yet. Do I need to add the update-mime-database thing too?

I don't completely understand it from here. for eg, what is a "MimeType key."?

http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#desktop-database

> I've spoken to upstream and there is no 'install' target, he doesn't have a use
> for one.

Do I still need to patch the .pro?
> 
> You are mixing macro styles, this is frowned upon by the guidelines:
> $RPM_BUILD_ROOT%{_bindir} should be something like %{buildroot}/%{_bindir}
> 

Corrected :)

> My version of the %description has more keywords, in particular for searching
> you really need 'hugin', 'vedutismo', 'stereographic', 'QuickTimeVR' and
> 'QTVR'. You should also try and get the singular 'panorama' and the alternative
> 'Pannini' spelling into the description:
> 
> > Panini can load most common photo and panoramic formats from image files such
> > as those created with hugin or QuickTimeVR (QTVR .mov) files.  Like all panorama
> > viewers, it then shows a linear perspective view that can be panned and zoomed.
> > But Panini can also display a range of wide angle perspectives via the
> > stereographic and "Pannini" vedutismo families of projections, and shift,
> > rotate, and stretch the image like a software view camera.  

I changed the spec to this one.. 

new spec and srpm:

http://ankursinha.fedorapeople.org/panini/Panini.spec

http://ankursinha.fedorapeople.org/panini/Panini-0.71.102-1.fc12.src.rpm

all the other mock build results are here (rpms etc.):

http://ankursinha.fedorapeople.org/panini/

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]